nucleic / kiwi

Efficient C++ implementation of the Cassowary constraint solving algorithm
https://kiwisolver.readthedocs.io/en/latest/
Other
692 stars 88 forks source link

3.13 support #183

Closed MatthieuDartiailh closed 2 months ago

codecov[bot] commented 2 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 87.88%. Comparing base (e7f7b86) to head (dd35b46). Report is 1 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #183 +/- ## ========================================== + Coverage 87.86% 87.88% +0.02% ========================================== Files 24 24 Lines 1632 1635 +3 Branches 69 84 +15 ========================================== + Hits 1434 1437 +3 Misses 184 184 Partials 14 14 ```
QuLogic commented 2 months ago

If dropping 3.7 support, you can also remove the KIWI_DISABLE_FH4 flag, cf https://github.com/matplotlib/matplotlib/pull/28725

neutrinoceros commented 2 months ago

Hi ! I don't know if that was intented, but I see that the 1.4.6 release only has one wheel for cp313. Namely, kiwisolver-1.4.6-cp313-cp313-win_arm64.whl

MatthieuDartiailh commented 2 months ago

I just checked PyPI and I see much more than one. Can you re-check ?

neutrinoceros commented 2 months ago

FWIW, I'm still seeing just the one (looking at https://pypi.org/simple/kiwisolver/) Could it be that I'm just served by an out-of-sync server ? I can just check again in an hour or so.

QuLogic commented 2 months ago

The build here shows only one 3.13 wheel being uploaded.

I think you may have run into the bug with upload-artifact/download-artifact that prompted their change to v4. To fix that, you would have to change uploading to use unique artifact names. See for example the GH104 error on repo-review, or the update in Matplotlib.

MatthieuDartiailh commented 2 months ago

I did mess up the CI configuration. I fixed it and I am running a test run. If it passes I will upload the new wheels later today.

neutrinoceros commented 2 months ago

thank you !