nucleos / NucleosDompdfBundle

📜 This bundle provides a wrapper for using dompdf inside symfony.
https://nucleos.rocks
MIT License
39 stars 12 forks source link

Update NucleosDompdfExtension.php Extension Injection #553

Closed Kitee666 closed 1 month ago

Kitee666 commented 1 month ago

Fix for Symfony 7.1

After upgrading to Symfony 7.1 I encountered a deprecation notice on your bundle.

The "Symfony\Component\HttpKernel\DependencyInjection\Extension" class is considered internal since Symfony 7.1, to be deprecated in 8.1; use Symfony\Component\DependencyInjection\Extension\Extension instead. It may change without further notice.

core23 commented 1 month ago

Can you please run php-cs-fixer

Kitee666 commented 1 month ago

Sure, sorry I forgor 😄 I'll do that as soon as I come back to work.

Kitee666 commented 1 month ago

495f717 have only php-cs-fixer fixes in extension files.

43787e7 have "fixes" to other files after running php-cs-fixer in project

6b0723b is just minor addition to composer with added "^7.1" at every symfony package.

I think I am just messing something up but I am not really sure what :(

Kitee666 commented 1 month ago

Sorry, I am kinda new to open source contributions. I usually work on my own projects or collaborate with in-domain developers; I hope it will work this time 😄

core23 commented 1 month ago

Thanks @Kitee666 🚀

Kitee666 commented 1 month ago

I am happy that I could help a little 😊 Thank you @core23 for creating this package!