search

nucleus-ffm / foss_warn

An unofficial open source application to get emergency alerts from https://warnung.bund.de/meldungen.
GNU General Public License v3.0
98 stars 6 forks source link

Wrong translation license #85

Closed comradekingu closed 1 year ago

comradekingu commented 1 year ago

https://hosted.weblate.org/projects/foss-warn/#information says AGPLv3-only, whereas https://github.com/nucleus-ffm/foss_warn/blob/main/LICENSE (not specified "only" or "or later"), so they aren't compatible.

https://github.com/nucleus-ffm/foss_warn/blob/ad09d8d29e197ccf7580c884fce51e1343c0314c/lib/views/aboutView.dart#L176 says GPLv3 (not specified "only" or "or later").

It would be better to make the translations GPLv3-or-later in https://hosted.weblate.org/settings/foss-warn/foss-warn-app/ https://hosted.weblate.org/settings/foss-warn/glossary/

And additionally specify "or later" or the code somewhere. Maybe I missed an intention to make it "GPLv3-only", but usually it is the case that people just select the wrong thing.

nucleus-ffm commented 1 year ago

Thanks for the hint. That was a mistake on my part. I changed the license in weblate to GPL v3.0.

comradekingu commented 1 year ago

@nucleus-ffm It still says "only", making it incompatible with for example going to AGPLv3, or combining code between the two. It also prevents the option of going to GPLv4 in the future if a new version is released. Is that intentional?

nucleus-ffm commented 1 year ago

@comradekingu That was actually indented, but maybe we should reconsider that decision. My initial thought was that I don't want to support a license that doesn't exist yet, because I can't know what's in the new license. And if there is a newer version of the GPL, I want to change it manually. But maybe there is no need to worry.

comradekingu commented 1 year ago

That is exactly what you have to do, it is not automatic. My worry is that you will be in a situation where you want to change, and then have to negotiate licensing with each and every translator.

nucleus-ffm commented 1 year ago

@comradekingu OK, your right. I have now selected GPLv3 or later in Weblate. So that should be fine now, right?

comradekingu commented 1 year ago

@nucleus-ffm Except it isn't pushing anything here. If you add "kingu" in https://hosted.weblate.org/access/foss-warn/#users I can have a look. Edit: https://docs.weblate.org/en/latest/admin/continuous.html#automatically-receiving-changes-from-github may help.

nucleus-ffm commented 1 year ago

@comradekingu Oh yes, I had to change the push URL. Now it seems to work: https://github.com/nucleus-ffm/foss_warn/commit/1016a8fc1b21592f33a1962cada4d394b4b29e45