search

nucleus-ffm / foss_warn

An unofficial open source application to get emergency alerts from https://warnung.bund.de/meldungen.
GNU General Public License v3.0
98 stars 6 forks source link

Bugfixes #95

Closed nucleus-ffm closed 10 months ago

nucleus-ffm commented 11 months ago
MatsG23 commented 10 months ago

Is the internal phone number change completed?

MatsG23 commented 10 months ago

For Android 14 I have added the function to request the SCHEDULE_EXACT_ALARM permission. Sadly this is a permission that needs to be given in the settings (the app opens the matching settings page - comparable to the battery excemption as it was before). I think that this needs a welcome page for the user to explain. Similar could optionally be done for the notification permission. The problem is that those one or two new pages would be a conditional welcome item (depending on the Android version). This is not compatible with our current aproach, I think. What are your thoughts on this?

nucleus-ffm commented 10 months ago

For Android 14 I have added the function to request the SCHEDULE_EXACT_ALARM permission. [...]

I would suggest doing this in a later version. Andoid 14 is really new and I think we can do this later. I still need to think about a solution. But we could also just show an alertDialog to ask for permission (for now).

nucleus-ffm commented 10 months ago

Is the internal phone number change completed?

You mean that the app converts e.g. the German numbers to international numbers? No, I haven't implemented that yet and I will try it later. We can create a issue to not forget this feature.

MatsG23 commented 10 months ago

I think the old web address extractor did not work with subdomains because it had some logic included that cuts after the first dot and adds a "https". This was likely made with only "www" subdomains in mind. I now created a regex and tests for that too and slightly improved the extraction from a hyperlinks (by searching for href=" instead of only the ").