search

nucleuscloud / neosync

Open source data anonymization and synthetic data orchestration for developers. Create high fidelity synthetic data and sync it across your environments.
https://www.neosync.dev
Other
3.34k stars 119 forks source link

NEOS-1338: Add support for checking the connection in the connect page #2588

Closed evisdrenova closed 2 months ago

evisdrenova commented 2 months ago

This adds in real time connection validation into the Connect page as the user selects a connection. It aims to solve/avoid two problems (that we've come across):

  1. People not testing their connections and then getting to the schema page and not understanding why their schema isn't loading.
  2. Something going wrong with a connection at some point in time before they configure the job and then they come back to it and the connection is no longer valid.

Similar to the test connection modal, possible responses are:

  1. Success
  2. Warning -> orange stop sign, usually means that we were able to connect but don't see anything. Also includes a link to the permissions table for more info.
  3. Errors -> unable to connect, takes them to the permissions table which has a longer explanation of the issue

Warnings and Errors don't stop the user from moving forward, just tell the user that something is potentially wrong.

Demo: https://www.loom.com/share/36d5b9edf19745bdbcf4c7312ba5c430?sid=6b80f535-4046-482f-8572-9f8dc99af3b3

linear[bot] commented 2 months ago

NEOS-1338 some sort of validation for connections in connect page to see which are still valid

vercel[bot] commented 2 months ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Skipped Deployment | Name | Status | Preview | Comments | Updated (UTC) | | :--- | :----- | :------ | :------- | :------ | | **neosync-docs** | ⬜️ Ignored ([Inspect](https://vercel.com/neosync/neosync-docs/5dg9oH6s4jeDgrq3b958xY5CtYwe)) | [Visit Preview](https://neosync-docs-git-connectioncheckinconnectpage-neosync.vercel.app) | | Sep 4, 2024 11:21pm |
github-actions[bot] commented 2 months ago

The latest Buf updates on your PR. Results from workflow Buf / buf (pull_request).

BuildFormatLintBreakingUpdated (UTC)
✅ passed✅ passed✅ passed✅ passedSep 4, 2024, 11:21 PM
codecov[bot] commented 2 months ago

Codecov Report

Attention: Patch coverage is 0% with 16 lines in your changes missing coverage. Please review.

Project coverage is 37.66%. Comparing base (3501212) to head (a491c95). Report is 23 commits behind head on main.

Files with missing lines Patch % Lines
...ces/mgmt/v1alpha1/connection-service/connection.go 0.00% 16 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #2588 +/- ## ========================================== - Coverage 38.45% 37.66% -0.80% ========================================== Files 263 266 +3 Lines 24532 24865 +333 ========================================== - Hits 9435 9366 -69 - Misses 13740 14190 +450 + Partials 1357 1309 -48 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

evisdrenova commented 2 months ago

yeah i considered that but didn't want to shove it all into one PR. I also need to add this to the source and destination pages in the job/[id] as well + a few other fast follows