Closed piotr-roslaniec closed 10 months ago
Attention: 18 lines
in your changes are missing coverage. Please review.
Comparison is base (
87c5f34
) 78.10% compared to head (17a18cd
) 78.54%.
Files | Patch % | Lines |
---|---|---|
ferveo/src/bindings_python.rs | 0.00% | 10 Missing :warning: |
ferveo/src/bindings_wasm.rs | 0.00% | 3 Missing :warning: |
ferveo/src/dkg.rs | 96.90% | 3 Missing :warning: |
ferveo/src/pvss.rs | 90.90% | 2 Missing :warning: |
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Replaced by #173
Type of PR:
Required reviews:
What this does:
n-of-m
we allow forn-of-[m, validators.len()]
to be considered a successful ceremonyshares_num
is effectively replaced byvalidators.len()
, and from now onshares_num
denotes the minimum number of shares (or validators) that the DKG ceremony accommodatesIssues fixed/closed:
Why it's needed:
Notes for reviewers: