Closed theref closed 3 weeks ago
@derekpierre not sure why but it won't let me respond directly to your comments.
Any thoughts on this @theref ? It would be nice to have it as a common constant.
You and I discussed the fact that A LOT of the testing code is being duplicated. This issue https://github.com/nucypher/nucypher-contracts/issues/284 was opened and we should add it to a sprint in the future, it would be a great piece of cleanup
You and I discussed the fact that A LOT of the testing code is being duplicated. This issue #284 was opened and we should add it to a sprint in the future, it would be a great piece of cleanup
Ah ok. It'll be eventually addressed as part of #284 - 👍
@cygnusv @vzotova
after deploying to lynx @KPrasch and I noticed that the owner of this contract is 0x0...00
address. I can see in other contracts that we do:
function initialize() external initializer {
__Ownable_init(msg.sender);
}
but that contract also has a _disableInitializers()
call at the end of it's constructor. I'm a bit confused :) what should we be doing here?
@cygnusv @vzotova after deploying to lynx @KPrasch and I noticed that the owner of this contract is
0x0...00
address. I can see in other contracts that we do:function initialize() external initializer { __Ownable_init(msg.sender); }
but that contract also has a
_disableInitializers()
call at the end of it's constructor. I'm a bit confused :) what should we be doing here?
Good question! We need to add the initialize function you suggest, and also keep the disableInitializers() call. The former has effect on the proxy state (which is what proxies are for) while the latter disables initializers on logic contracts.
Scope is outlined in #266
Related to https://github.com/nucypher/sprints/issues/35