nucypher / nucypher-contracts

Ethereum contracts supporting TACo applications on the Threshold Network.
16 stars 11 forks source link

[EPIC] New fee model architecture #270

Closed vzotova closed 4 weeks ago

vzotova commented 3 months ago

Type of PR:

Required reviews:

What this does: Changes fee model, now it's separate contract that must be approved in coordinator. Implements subscription for BqETH

Issues fixed/closed:

PRs:

Why it's needed:

Explain how this PR fits in the greater context of the NuCypher Network. E.g., if this PR address a nucypher/productdev issue, let reviewers know!

Notes for reviewers: This PR is ready for tests and integration with nucypher repo, ManagedAllowList needs touch up in some of following PRs

derekpierre commented 1 month ago

Just rebased this EPIC. Given the size of this PR - we should try to merge this soon. That being said, we should not merge it until v7.4.0 is released since merging it will cause nucypher/nucypher acceptance tests to fail because of contract changes. PR https://github.com/nucypher/nucypher/pull/3535 should remedy those issues moving forward, in the v7.5.x branch, once this PR is merged into main.