search

nucypher / nucypher-contracts

Ethereum contracts supporting TACo applications on the Threshold Network.
16 stars 11 forks source link

Bqeth testing and usage script #289

Closed theref closed 3 weeks ago

theref commented 2 months ago

Closes https://github.com/orgs/nucypher/projects/55/views/1?pane=issue&itemId=69683595

theref commented 1 month ago

@KPrasch do we still need this with #299 ?

KPrasch commented 1 month ago

@KPrasch do we still need this with #299 ?

Do you mean this entire PR? This script broke the ice for testnet fee model deployments but I'm in favor of closing this PR as long as you feel that all of the useful bits have been included elsewhere. Also, I want to acknowledge that #299 is based off your initial work here (I made sure to include you as a commit author).

That being said (almost) all of the functionality implemented in this PR has been implemented in #299 and #297. The main difference is that this PR has fewer dependencies (#299 heavily depends on eth-ape abstractions). Personally, I do not view that as a major issue. There are a few interesting bits of logic here, particularly with regard to ritual duration calculation that I'd like to understand better so we may possibly include the same changes in #297. (see https://github.com/nucypher/nucypher-contracts/pull/289#discussion_r1706563297)

Additional thoughts?

KPrasch commented 3 weeks ago

This branch was closed by automation after deleting the epic-subscription branch. I suggest making a new PR into main for any additional follow-ups.