search

nucypher / nucypher-contracts

Ethereum contracts supporting TACo applications on the Threshold Network.
16 stars 11 forks source link

Upgrade Tapir contracts to be inline with mainnet #308

Closed theref closed 2 weeks ago

theref commented 3 weeks ago
derekpierre commented 2 weeks ago

@theref two outstanding items that we should do before merging this PR:

  1. We have some conflicting formatting actions between the deployment code used to generate the registry, and the pre-commit linter. See https://github.com/nucypher/nucypher-contracts/pull/312#discussion_r1728847318. For now let's keep the non-linter modified version so that the registry diff is easier to review.

Consequently can you run:

ape run normalize_registry --registry ./deployment/artifacts/tapir.json

to normalize the registry format back to what was produced by the deployment scripts. Then when committing the update to the format of the registry simply run:

git commit --no-verify

So that the automated linter doesn't update the format.

This is something that will be addressed in a separate issue/PR; filed #319 .

  1. Verify the BQeth Subscription contract on the polygon scan for Amoy. Have you used https://github.com/nucypher/nucypher-contracts-verification before for storing the solidity files used for verification? If you haven't before, ping me and we can go through it quickly.
theref commented 2 weeks ago

Fixed the formatting and verified the contract https://amoy.polygonscan.com/address/0xC3085b0feB8C348D0BD7fabF4299c93dc2aE11d7#writeProxyContract