Closed derekpierre closed 1 year ago
Merging #74 (ef2568d) into main (d1a9cad) will increase coverage by
2.16%
. The diff coverage is39.75%
.
@@ Coverage Diff @@
## main #74 +/- ##
==========================================
+ Coverage 21.22% 23.38% +2.16%
==========================================
Files 16 18 +2
Lines 3176 3540 +364
==========================================
+ Hits 674 828 +154
- Misses 2502 2712 +210
Files Changed | Coverage Δ | |
---|---|---|
nucypher-core-python/src/lib.rs | 0.00% <0.00%> (ø) |
|
nucypher-core-wasm/src/lib.rs | 0.00% <0.00%> (ø) |
|
nucypher-core/src/conditions.rs | 53.84% <ø> (ø) |
|
nucypher-core/src/threshold_message_kit.rs | 80.70% <80.70%> (ø) |
|
nucypher-core/src/access_control.rs | 87.06% <87.06%> (ø) |
|
nucypher-core/src/dkg.rs | 89.80% <100.00%> (+0.14%) |
:arrow_up: |
I think it might be better to extract the permanent-support objects into a separate PR, because it's pretty important and shouldn't be mixed up with the rest of the stuff that's going on here.
I think it might be better to extract the permanent-support objects into a separate PR, because it's pretty important and shouldn't be mixed up with the rest of the stuff that's going on here.
Removed the functionality from this PR and moved to https://github.com/nucypher/nucypher-core/pull/75.
Type of PR:
Required reviews:
What this does:
Issues fixed/closed: Depends on https://github.com/nucypher/ferveo/pull/156 Related to https://github.com/nucypher/nucypher/pull/3194
Why it's needed:
Notes for reviewers: