nucypher / nucypher-core

Core structures for Nucypher network in Rust
6 stars 11 forks source link

Conditions should not be optional for CBD types #80

Closed derekpierre closed 1 year ago

derekpierre commented 1 year ago

…ata and AccessControlPolicy.

Type of PR:

Required reviews:

What this does:

High-level idea of the changes introduced in this PR. List relevant API changes (if any), as well as related PRs and issues.

Issues fixed/closed: Related to #76 .

Why it's needed: Conditions should not be optional for CBD - it's kind of the whole point.

Notes for reviewers:

What should reviewers focus on? Is there a particular commit/function/section of your PR that requires more attention from reviewers?

Already ran parts of the test suite locally with nucypher to test python bindings. There are no downstream changes necessary for nucypher other than an updated nucypher-core dependency, because conditions were not optional for CBD functionality in nucypher anyway.