search

nucypher / nucypher-ops

GNU General Public License v3.0
3 stars 8 forks source link

Update nucypher-ops to be compatible with ansible v8+ #29

Open derekpierre opened 1 year ago

derekpierre commented 1 year ago

There seem to be some updates with ansible v8+ that we need to take into consideration:

  1. Error occurs when running playbook 
    File "/Users/derek/.local/share/virtualenvs/nucypher-ops-5Pl1T8Sp/lib/python3.10/site-packages/ansible/utils/collection_loader/_collection_config.py", line 87, in playbook_paths
cls._require_finder()
File "/Users/derek/.local/share/virtualenvs/nucypher-ops-5Pl1T8Sp/lib/python3.10/site-packages/ansible/utils/collection_loader/_collection_config.py", line 97, in _require_finder
raise NotImplementedError('an AnsibleCollectionFinder has not been installed in this process')
NotImplementedError: an AnsibleCollectionFinder has not been installed in this process
  2. The package ansible-lint seems to complain about our playbook structure: For example: 
    $ ansible-lint --offline -p nucypher_ops/playbooks/get_workers_status.yml
WARNING  Listing 30 violation(s) that are fatal
nucypher_ops/playbooks/get_workers_status.yml:5: name[play]: All plays should be named.
nucypher_ops/playbooks/include/check_running_ursula.yml:4: yaml[truthy]: Truthy value should be one of
nucypher_ops/playbooks/include/check_running_ursula.yml:7: fqcn[action-core]: Use FQCN for builtin module actions (uri).
nucypher_ops/playbooks/include/check_running_ursula.yml:10: yaml[truthy]: Truthy value should be one of
nucypher_ops/playbooks/include/check_running_ursula.yml:13: fqcn[action-core]: Use FQCN for builtin module actions (shell).
nucypher_ops/playbooks/include/check_running_ursula.yml:13: no-changed-when: Commands should not change things if nothing needs doing.
nucypher_ops/playbooks/include/check_running_ursula.yml:13: risky-shell-pipe: Shells that use pipes should set the pipefail option.
nucypher_ops/playbooks/include/check_running_ursula.yml:14: yaml[truthy]: Truthy value should be one of
nucypher_ops/playbooks/include/check_running_ursula.yml:19: fqcn[action-core]: Use FQCN for builtin module actions (lineinfile).
...

These 2 items may or may not be related. For now the version of ansible is restricted to 7.7.0 until we make these updates - #28 .