search

nucypher / nucypher-ops

GNU General Public License v3.0
3 stars 8 forks source link

tbtcv2 arg compat fix #34

Open vepkenez opened 10 months ago

vepkenez commented 10 months ago

Type of PR:

Required reviews:

What this does: Found a bug when doing: nucypher-ops tbtcv2 run the arg name mismatch was causing an Ansible "this variable does not exist" error. Deployment failed. This patch allows it to succeed with no additional changes.

this commit was made for Ursula: https://github.com/nucypher/nucypher-ops/blame/326e2918ff583bb5a11bb097ea9737720d00fd3d/nucypher_ops/templates/ursula_inventory.mako#L36

This PR does the same for tbtcv2 and Porter

derekpierre commented 10 months ago

Great to see you again @vepkenez ! 🤗 Thanks for the fix.

Just as an aside, admittedly, we are trying to wind down the use of nucypher-ops. It's a lot of maintenance and it breeds a measure of complacency for node operators with nucypher-ops handling much of the operational key/secrets management for them; not necessarily a good thing given the increased sensitivity of material used for tBTC and TACo. We want node operators to actively understand what they are doing (instead of passively), and what needs to be backed up and kept secret. This also ties in with the node set up process being much more simple than before.