search

nucypher / nucypher-porter

Gateway to TACo nodes of the threshold network
GNU Affero General Public License v3.0
2 stars 8 forks source link

Porter Monitoring/Status functionality #4

Closed derekpierre closed 1 year ago

derekpierre commented 3 years ago

Should we consider:

  1. Having a simple status type page for Porter
  2. Monitoring/Alerting type functionality for Porter; perhaps a prometheus type setup.
KPrasch commented 1 year ago

Now that we're including the version field in porter requests I don't think we have any further needs right now. Let's make this as wontfix and close it?

derekpierre commented 1 year ago

I think this issue was broader reaching and more long-term:

  1. Having a porter instance status page - like ursula's status page to provide information about learning
  2. General Porter statistics like learning, uptime, etc. - this is along the lines of a prometheus endpoint analogous to what we hope to implement for Ursula.
KPrasch commented 1 year ago

Having a porter instance status page - like ursula's status page to provide information about learning

imo It's overkill, network-wide dashboards can be created in other ways that don't add to the overhead of this codebase.

General Porter statistics like learning, uptime, etc. - this is along the lines of a prometheus endpoint analogous to what we hope to implement for Ursula.

System metrics like service uptime can be handled by 3rd party services like node-exporter, so I think this one is a non-issue. Grafana can already directly consume porter JSON endpoints so I'm unsure what we'd really be gaining from a prometheus exporter integration that can't already be known from the JSON endpoints.

These are fine ideas, just not worth the effort vs. gain. Perhaps "nice to haves" ? My vote is wontfix.