search

nucypher / nucypher-porter

Gateway to TACo nodes of the threshold network
GNU Affero General Public License v3.0
2 stars 8 forks source link

Duration Sampling #67

Closed derekpierre closed 6 months ago

derekpierre commented 7 months ago

Depends on https://github.com/nucypher/nucypher/pull/3491.

Before merging this PR there should be an update to the Pipfile to use nucypher branch v7.3.x after PR 3491 is merged.

Type of PR:

Required reviews:

What this does:

High-level idea of the changes introduced in this PR. List relevant API changes (if any), as well as related PRs and issues.

Allows optional duration parameter to be specified for the /bucket_sampling and /get_ursulas Porter endpoints.

Issues fixed/closed:

  • Fixes #...

Why it's needed:

Explain how this PR fits in the greater context of the NuCypher Network. E.g., if this PR addresses a nucypher/productdev issue, let reviewers know!

Notes for reviewers:

What should reviewers focus on? Is there a particular commit/function/section of your PR that requires more attention from reviewers?

codecov-commenter commented 6 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 87.31%. Comparing base (5d6a416) to head (c1b7e65).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## development #67 +/- ## ================================================ + Coverage 0 87.31% +87.31% ================================================ Files 0 18 +18 Lines 0 867 +867 ================================================ + Hits 0 757 +757 - Misses 0 110 +110 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.