nucypher / nucypher-porter

Gateway to TACo nodes of the threshold network
GNU Affero General Public License v3.0
2 stars 8 forks source link

Increase Max timeout for `get_ursulas`/`bucket_sampling`; fix faulty env variable usage #77

Closed derekpierre closed 1 week ago

derekpierre commented 1 week ago

Type of PR:

Required reviews:

What this does:

Issues fixed/closed:

  • Fixes #...

Why it's needed:

Explain how this PR fits in the greater context of the NuCypher Network. E.g., if this PR addresses a nucypher/productdev issue, let reviewers know!

Notes for reviewers:

What should reviewers focus on? Is there a particular commit/function/section of your PR that requires more attention from reviewers?

codecov-commenter commented 1 week ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 90.57%. Comparing base (d540b7c) to head (8224acc).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## development #77 +/- ## =============================================== + Coverage 90.55% 90.57% +0.02% =============================================== Files 18 18 Lines 900 902 +2 =============================================== + Hits 815 817 +2 Misses 85 85 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

theref commented 1 week ago

separate investigation can be done into efficiency improvments

is there an issue for this?

derekpierre commented 1 week ago

separate investigation can be done into efficiency improvments

is there an issue for this?

There is one now - https://github.com/nucypher/nucypher-porter/issues/78 - 😆