search

nucypher / stakeit.space

NuCypher's fork of @ronmnm 's stakeit.space
GNU Affero General Public License v3.0
5 stars 4 forks source link

Mainnet Readiness #5

Closed KPrasch closed 4 years ago

KPrasch commented 4 years ago

Based on #1

KPrasch commented 4 years ago

@vepkenez

In my opinion, all of these contract addresses should be in a .env file or at least in a constants file. It should be very easy to audit their correctness without hunting for them throughout the code. ...This is the primary concern.

There already is such a module: instances.js. These addresses are not secret, completely public, and will never change.

To me that means "Hardcoded"