search

nucypher / taco-web

🌮 A TypeScript client for TACo (Threshold Access Control)
https://docs.threshold.network/app-development/threshold-access-control-tac
GNU General Public License v3.0
16 stars 23 forks source link

refactor: taco nodejs example #417

Closed DeMonkeyCoder closed 11 months ago

DeMonkeyCoder commented 11 months ago

Type of PR:

Required reviews:

What this does: Adds a more clear and understandable example code for Taco by separating the encrypt and decrypt functions

Why it's needed: It was not clear in the example how to create an encrypted message, send it somewhere else, and decrypt it later. The decryption code parts were using objects from encryption. So I separated encrypt and decrypt functions to show the users how they can be separately used.

netlify[bot] commented 11 months ago

Deploy Preview for taco-demo canceled.

Name Link
Latest commit a0f020909412b88203226d6e64715f474817ad65
Latest deploy log https://app.netlify.com/sites/taco-demo/deploys/65606d3e8f2f6d0008913c4e
netlify[bot] commented 11 months ago

Deploy Preview for taco-nft-demo canceled.

Name Link
Latest commit a0f020909412b88203226d6e64715f474817ad65
Latest deploy log https://app.netlify.com/sites/taco-nft-demo/deploys/65606d3edb2c250008028dbd
codecov-commenter commented 11 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (ad99762) 88.00% compared to head (a0f0209) 87.98%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #417 +/- ## ========================================== - Coverage 88.00% 87.98% -0.02% ========================================== Files 33 33 Lines 2701 2697 -4 Branches 232 232 ========================================== - Hits 2377 2373 -4 Misses 293 293 Partials 31 31 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

piotr-roslaniec commented 11 months ago

Thanks @alimahdiyar