Ensure signature freshness on client side

nucypher / taco-web

🌮 A TypeScript client for TACo (Threshold Access Control)

https://docs.threshold.network/app-development/threshold-access-control-tac

GNU General Public License v3.0

14 stars 22 forks source link

Ensure signature freshness on client side #452

Closed piotr-roslaniec closed 2 weeks ago

piotr-roslaniec commented 8 months ago

Currently, we're storing and returning signatures without discriminating for blockNumber they were made at: https://github.com/nucypher/taco-web/blob/main/packages/taco/src/conditions/context/providers.ts#L20-L20
Ensure that the signature is fresh according to the set criteria before returning it from the cache
Consider adding signature freshness as a Condition parameter
Refers to: https://github.com/nucypher/tdec/issues/50

derekpierre commented 8 months ago

derekpierre commented 2 weeks ago

We are transitioning to SIWE which has an issuedAt property. This property is checked for 2h freshness (same freshness used by nodes) when retrieving from cache via #567 .