nucypher / taco-web

🌮 A TypeScript client for TACo (Threshold Access Control)
https://docs.threshold.network/app-development/threshold-access-control-tac
GNU General Public License v3.0
15 stars 23 forks source link

Test npm package availability on CI #510

Closed piotr-roslaniec closed 5 months ago

piotr-roslaniec commented 5 months ago

Type of PR:

Required reviews:

What this does:

Why it's needed:

netlify[bot] commented 5 months ago

Deploy Preview for taco-demo canceled.

Name Link
Latest commit 147b09d3817bdefd144fb648f87c4db50bd4cae8
Latest deploy log https://app.netlify.com/sites/taco-demo/deploys/661ad7fab40e8b0008d3b074
netlify[bot] commented 5 months ago

Deploy Preview for taco-nft-demo canceled.

Name Link
Latest commit 147b09d3817bdefd144fb648f87c4db50bd4cae8
Latest deploy log https://app.netlify.com/sites/taco-nft-demo/deploys/661ad7faf37290000814c3ba
piotr-roslaniec commented 5 months ago

We are publishing packages manually (Codechecks will work great after we release 1.0.0: https://github.com/nucypher/taco-web/pull/460). So having to run this job is just one more thing we need to remember to do.

NPM tags can also change without publishing a new version. For example, a change on lynx followed by a change on tapir will require us to release a new version for lynx and then tag it again for tapir.

It doesn't make a huge difference to me whether this job runs every hour or every 24 hours. I think the sooner we catch this the better. If we do this every 24 hours then we spend 24 less compute, but I don't think compute spent is an issue.

manumonti commented 5 months ago

Got it, thanks! it makes more sense to me now.