Allow reusing SIWE messages in EIP4361-based condition authentication

nucypher / taco-web

🌮 A TypeScript client for TACo (Threshold Access Control)

https://docs.threshold.network/app-development/threshold-access-control-tac

GNU General Public License v3.0

14 stars 20 forks source link

Allow reusing SIWE messages in EIP4361-based condition authentication #529

Closed piotr-roslaniec closed 2 weeks ago

piotr-roslaniec commented 1 month ago

Type of PR:

Feature

Required reviews:

What this does:

Allows reusing of existing SIWE messages by providing them as a context parameter at decryption time
Internally, it reuses the :userAddressEIP4361 context parameter - Hence, no changes on the server side required.

Issues fixed/closed:

Fixes #528

Notes for reviewers:

Context variable handling may still change post https://github.com/nucypher/tdec/issues/179

piotr-roslaniec commented 1 month ago

Sending review requests for an early review of this draft

piotr-roslaniec commented 4 weeks ago

Asking for review despite some rough edges to confirm the design

piotr-roslaniec commented 3 weeks ago

@derekpierre I think we can rebase this over #531.

I added a public method to the EIP4361 auth provider to expose message-creating logic to end-users.

piotr-roslaniec commented 3 weeks ago

Rebased over https://github.com/nucypher/taco-web/pull/531

piotr-roslaniec commented 3 weeks ago

Thoughts?

I think AuthSignature will become a class rather than an interface, and we will add more utilities and conversion functions as we go. Adding more factory methods, especially for SIWE, makes sense. I will look into it.

piotr-roslaniec commented 2 weeks ago

I'm going to go ahead and merge this, but we can continue discussing here or in #537 if anything