search

nucypher / taco-web

🌮 A TypeScript client for TACo (Threshold Access Control)
https://docs.threshold.network/app-development/threshold-access-control-tac
GNU General Public License v3.0
14 stars 22 forks source link

Add JsonApiCondition #550

Closed theref closed 1 month ago

theref commented 2 months ago

Fixes https://github.com/nucypher/sprints/issues/23

netlify[bot] commented 2 months ago

Deploy Preview for taco-nft-demo ready!

Name Link
Latest commit be45583092a2fde7e7df638075af0fa467a7e285
Latest deploy log https://app.netlify.com/sites/taco-nft-demo/deploys/66a8f21fd4779e00080c641d
Deploy Preview https://deploy-preview-550--taco-nft-demo.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

netlify[bot] commented 2 months ago

Deploy Preview for taco-demo ready!

Name Link
Latest commit be45583092a2fde7e7df638075af0fa467a7e285
Latest deploy log https://app.netlify.com/sites/taco-demo/deploys/66a8f21f05d49c0009ffaf26
Deploy Preview https://deploy-preview-550--taco-demo.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

derekpierre commented 1 month ago

Just a side note - I don't think this should go into main; at least not yet. The next release of taco-web (SIWE etc.) should not have this code.

JsonApiCondition needs to be released on the server-side first and won't be released until 7.5.0. Perhaps instead you merge this PR into an epic/dev branch for now? Perhaps there's an existing alternative strategy that @piotr-roslaniec already uses...?

theref commented 1 month ago

The original issue https://github.com/nucypher/sprints/issues/23 specifically says "Get taco-web preemptively compatible..." so I assumed there was some reason for having this merged before 7.5.0 is release

derekpierre commented 1 month ago

The original issue nucypher/sprints#23 specifically says "Get taco-web preemptively compatible..." so I assumed there was some reason for having this merged before 7.5.0 is release

Yep. The goal is for everyone to start getting more familiar with taco-web. This task pushes that forward.

The "pre-emptive" part is what I'm referring to. The code will be used, just not in the next release of taco-web. The next release of taco-web pretty much boils down to Sign-in With Ethereum support (https://github.com/nucypher/taco-web/pull/527 and some other fixes). If we merge this PR into main then it will be co-mingled with SIWE support which is not what we want. These are the steps for nucypher 7.4.0 release and subsequent taco-web release - https://github.com/nucypher/sprints/issues/5#issuecomment-2209378181.

Then a similar set of steps for the 7.5.0 nucypher release (w/ JsonApiCondition support) and subsequent taco-web release but instead of SIWE it'll be the JsonApiCondition feature.