Closed derekpierre closed 3 weeks ago
Name | Link |
---|---|
Latest commit | 1e528aa196c4a774a192a4dcde1d1f09e31d06cf |
Latest deploy log | https://app.netlify.com/sites/taco-demo/deploys/66c34d496107d700081b651e |
Name | Link |
---|---|
Latest commit | 1e528aa196c4a774a192a4dcde1d1f09e31d06cf |
Latest deploy log | https://app.netlify.com/sites/taco-nft-demo/deploys/66c34d49e5f0e00008da6d60 |
Replaces https://github.com/nucypher/taco-web/pull/554 which was auto-closed once epic-auth
was merged.
Attention: Patch coverage is 76.44231%
with 49 lines
in your changes missing coverage. Please review.
Project coverage is 79.10%. Comparing base (
e8f9098
) to head (1e528aa
). Report is 155 commits behind head on main.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
requestedContextParameters = conditionContext.requestedContextParameters // list of context variables required for underlying condition // Devs can loop over the list and populate context variables appropriately.
Could we get an example of iterating over this?
Great idea - added an illustrative optional example to the nodejs example - see https://github.com/nucypher/taco-web/pull/560/commits/1e528aa196c4a774a192a4dcde1d1f09e31d06cf.
Type of PR:
Required reviews:
What this does:
ConditionContext
instead of splitting up params for authProvider and customParameters.ConditionContext
to be populated by developers with authProviders and customParameters before being used for decryptionThe updated use of the code will look like the following:
Create condition context from message kit:
Add any required auth provider(s):
Add auth provider for
:userAddress
, if necessary:Add auth provider for
:userAddressExternalEIP4361
, if necessary:Add any required custom context variables, if necessary:
Call decrypt
Additionally, developers can also better query what parameters are needed for a condition in a message kit. This helps when apps have various permutations of conditions that they use, which include different parameters:
Issues fixed/closed:
Why it's needed:
Notes for reviewers: