Migrate from tap to jest

nudibranchrecords / hedron

Perform live shows with your three.js creations

GNU Affero General Public License v3.0

476 stars 22 forks source link

Migrate from tap to jest #121

Open funwithtriangles opened 5 years ago

funwithtriangles commented 5 years ago

Tap seemed like a nice simple solution but there have been lots of problems using it, specifically around decent reporting in the terminal. Objects are not being diffed correctly, causing all sorts of issues. My fear is that going forward there will only be more issues using a library that is not commonly used and maintained.

Jest seems to be the tool of choice these days, so I'll have to do a big migration.

Tests that are commented out and need reworking:

[ ] Input Links, Sagas
[ ] Inputs, Sagas
[ ] Macros, Sagas
[ ] Mock tests, scenes
[ ] Mock tests, sketches

funwithtriangles commented 5 years ago

Some tests are currently disabled: https://github.com/nudibranchrecords/hedron/commit/67dd1e15b7865d3f243447686f1c31c22645690f

At some point will be worth doing an audit and working out a sane testing trategy

funwithtriangles commented 5 years ago

mockTests now disabled due to window variable breaking everything (in utils/uiEventEmitter)

I think jest will make it easier to set up a better env for global vars etc

funwithtriangles commented 5 years ago

Migration doesn't have to happen in one go. Can be done incrementally, allowing new tests to be made with jest.

funwithtriangles commented 5 years ago

Security alert due to the tar package is because tape-watch hasn't been updated in years. Will be fixed once we've migrated.