nudibranchrecords / hedron

Perform live shows with your three.js creations
GNU Affero General Public License v3.0
480 stars 22 forks source link

[WIP] Type fixes #457

Closed funwithtriangles closed 3 weeks ago

funwithtriangles commented 1 month ago

Went through and fixed a bunch of TS issues and linting. The biggest change is forcing imports to always be using aliases. You can never use relative imports. So basically an import always has to start with @renderer, @main, @engine, @components, etc. We can add more aliases as we go.

@cale-bradbury what do you think? Too strict? I'm not even allowing neighbouring imports like ./foo, only exception is ./MyComponent.module.css.

I'm not too precious over this, just wanted to get some consistency across the codebase, let me know if you hate it! It's worth noting that VSCode's auto import when typing out a variable should automatically use this format so no issues there (let me know if that's the case for you!)

⚠️ Note to self: Don't merge this until the other PRs are merged

funwithtriangles commented 3 weeks ago

Merging for now, not sure if it all makes complete sense but we can still change rules if we start getting annoyed by them