search

nudj / nudj-backend

Nudj - Backend (Archive)
0 stars 0 forks source link

Exceptions thrown for the "fake" tester accounts #21

Closed richardbuckle closed 8 years ago

richardbuckle commented 8 years ago

Looking at the server logs I noticed that the "fake" phone numbers and missing Apple Push Notification tokens for the user Alice Tester and Bob Tester are causing exceptions to be thrown. Examples attached exception.log.txt

.

I am not sure whether these are benign or not so I thought I should mention them in case they are putting the server into a bad state.

richardbuckle commented 8 years ago

Pascal, could you please advise whether these are benign?

shtukas commented 8 years ago

I remember that whole discussion about phone numbers few months ago.... and how she should use approved fake numbers. In this case the call is actually failing, it's not benign, Twilio is rejecting the request, with the message "To number: +447700900002, is not a mobile number". I am not surprised that they do not want to deliver messages to numbers they know are fake.

Any suggestions ?

richardbuckle commented 8 years ago

Sorry, I didn't explain properly. My concern is not that the exceptions are being thrown but that they aren't being caught. I don't know PHP well enough to know whether uncaught exceptions can cause the server to end up in an inconsistent state.

shtukas commented 8 years ago

I don't know PHP well enough to know whether uncaught exceptions can cause the server to end up in an inconsistent state.

No harm.