search

nudj / nudj-backend

Nudj - Backend (Archive)
0 stars 0 forks source link

Amend currency display on mobileweb #24

Closed richardbuckle closed 8 years ago

richardbuckle commented 8 years ago

Steps to reproduce: View https://mobileweb-dev.nudj.co/jobpreview/48 - the bonus currency for this job is USD. Expected: bonus to read "USD 234". Observed: bonus reads "£ 234.00". Expected: salary to read "TBA". Observed: salary reads "£ TBA".

The bonus amount should be formatted with the browser's locale as currency style with no decimal part using the ISO currency code in the database, e.g. (warning Javascript not tested): number.toLocaleString( { style: 'currency', currency: 'USD', maximumFractionDigits: 0 })

The salary amount is free text so should not have additional formatting.

shtukas commented 8 years ago

This (the problem with the extra or incorrect £ symbol) should have been corrected in DEV. I need to push a different commit for the formatting of the numbers (this is done server side, not client side).

shtukas commented 8 years ago

Pushed to prod.

richardbuckle commented 8 years ago

Verified.