search

nuejs / create-nue

A recommended way to start a Nue project
https://nuejs.org
139 stars 30 forks source link

Feature/separation of concerns #6

Closed josesaranda closed 12 months ago

josesaranda commented 1 year ago

Hey yay! I just jumped in this project by coincidence. It looks promising 🚀.

I'd like to contribute with this PR! (just a few improvements, I think 🤔)

  1. Add prettier
  2. Move content to his own folder (separation of concerns)

I hope it will be useful 💃🏻!

tipiirai commented 1 year ago

Thanks!

I see quite a few other changes on this commit than just the two you mentioned (which I like). There is some formatting that should be communicated first so that we have a mutual style. For example, I'm strongly against XML style tag endings (/>) in places where they are not necessary

josesaranda commented 12 months ago

You're right! I also added .prettierrc file just to unify code styling. I just used recommended based Prettier styles, but we can agreed which ones we're going to use. About XML style tag endings /> are use by almost frameworks and ui's libraries like React, Astro, ... even Angular is thinking in adding it to their next version.

tipiirai commented 12 months ago

I can see quite many conflicts here after merging #16 . Is it possible to merge the above stuff in two separate PR's?

  1. The addition of prettier config + only changes that are not compatible with the config. I currently see only two lines in there which I completely agree on 
{
  "singleQuote": true,
  "semi": false
}
  1. Another PR to put the content inside a separate folder. However, given the nature of the app currently this is no more separate than place the file inside a folder. Or what do you think?

Is there a good, recent writing about the XML style tag endings?

Thank you!!

tipiirai commented 12 months ago

Closing this PR in favor to https://github.com/nuejs/create-nue/issues/21