Nuemark2.0 issues

[tomByrer]

Doing a quick code review of your dev branch, I am confused if the Blocks or Inline is scanned first? If Blocks, then it seems this code:

 *** Bold Italic ***

Would render as an <hr> since you are just scanning first few characters.?

Also be aware that CommonMark is VERY flexible for <hr>. I personally don't think you need to cover every edge case, but it could help to document "Only the common Markdown/CommonMark rules are covered."

[nobkd]

@tipiirai

[![](someimagelink)](somelink) in nuemark2 breaks the nue server and generator.

I used [![](/img/blog-build.png)](/) on a random page in the docs, and the server just hangs indefinitely

I know, that this is possible using markdown extensions (e.g. [! /img/blog-build.png href="/"]), but the default Markdown variant should still work imo.

---

The next ones generate and don't let the server hang, but still generate unexpected output:

Markdown	HTML
[[! yo.svg]](/)	<p>&lt;[! custom=&quot;[!&quot;&gt;<script type="application/json">{"_":"yo.svg"}</script>](/)</p>
[[my-tag]](/)	<p>&lt;[my-tag custom=&quot;[my-tag&quot;&gt;](/)</p>

[nobkd]

Btw I tried your example and this *** Bold Italic *** renders to nothing (mabye a section split??? idk) in my test on a doc page.

I also tested *** Bold Italic *** and it generates <p><strong>* Bold Italic</strong>*</p> but I think it should generate <p>*** Bold Italic ***</p>.

[nobkd]

@tipiirai just so you know, dev branch fails to build the docs (when there's no current .dist) since table changes:

Files where it fails on [table]:

• packages/nuejs.org/docs/syntax-highlighting.md
• packages/nuejs.org/blog/rethinking-reactivity/index.md

Error message:

227 | 
228 |   const html = rows.map((row, i) => {
229 |     const is_head = head && i == 0
230 |     const is_foot = table.foot && i > 1 && i == rows.length - 1
231 | 
232 |     const cells = row.map(td => elem(is_head || is_foot ? 'th' : 'td', renderInline(td, md_opts)))
                            ^
TypeError: row.map is not a function. (In 'row.map((td) => elem(is_head || is_foot ? "th" : "td", renderInline(td, md_opts)))', 'row.map' is undefined)
      at .../nue/packages/nuemark/src/render-tag.js:232:23
      at map (1:11)
      at renderTable (.../nue/packages/nuemark/src/render-tag.js:228:21)
      at table (.../nue/packages/nuemark/src/render-tag.js:98:18)
      at map (1:11)
      at renderBlocks (.../nue/packages/nuemark/src/render-blocks.js:18:17)
      at renderPage (.../nue/packages/nuekit/src/layout/page.js:128:23)
      at .../nue/packages/nuekit/src/nuekit.js:125:22

[tipiirai]

@tomByrer @nobkd fixed all issues mentioned on this article

[nobkd]

Thank youu! I'll check later today, if I find more unexpected results :)

[nobkd]

Input	Expected (Commonmark Spec Implementation)	Nuemark 2
```md *test** **test*** ***test**** - - - ****test*** ***test** **test* ```	```html test* test* test* *test *test *test ```	```html test* test* test* *test ***test** **test* ```

The first half (before hr) is correct, the second half is wrong (e.g. position of * in first after hr).

PS: I started building a test using the commonmark-spec test suite. See https://github.com/nuejs/nue/compare/dev...nobkd:nue:test/cmark-spec. Maybe you want to try using it.

[nobkd]

Oh, i just let the cmark tests run through without expect once, and the following Markdown tests let nuemark hang (this completely ignores all the other failing test):

Hanging tests by test number: [573, 576, 577, 582, 583, 584, 585, 586, 587, 588, 589, 590, 591, 629] (for now excluded in my branch: https://github.com/nuejs/nue/compare/dev...nobkd:nue:test/cmark-spec)

show hanging tests: category; test number; md

`Images; 573` ```md ![foo *bar*] [foo *bar*]: train.jpg "train & tracks" ``` --- `Images; 576` ```md ![foo *bar*][] [foo *bar*]: train.jpg "train & tracks" ``` --- `Images; 577` ```md ![foo *bar*][foobar [FOOBAR]: train.jpg "train & tracks" ``` --- `Images; 582` ```md ![foo][bar] [bar]: /url ``` --- `Images; 583` ```md ![foo][bar] [BAR]: /url ``` --- `Images; 584` ```md ![foo][] [foo]: /url "title" ``` --- `Images; 585` ```md ![*foo* bar][] [*foo* bar]: /url "title" ``` --- `Images; 586` ```md ![Foo][] [foo]: /url "title" ``` --- `Images; 587` ```md ![foo] [] [foo]: /url "title" ``` --- `Images; 588` ```md ![foo] [foo]: /url "title" ``` --- `Images; 589` ```md ![*foo* bar] [*foo* bar]: /url "title" ``` --- `Images; 590` ```md ![[foo]] [[foo]]: /url "title" ``` --- `Images; 591` ```md ![Foo] [foo]: /url "title" ``` --- `Raw HTML; 629` ```md foo &<]]> ```

Edit: there are probably more...

[tipiirai]

No more loops with unclosed image tags such as ![foo *bar*]

[tipiirai]

Are image reflinks like ![foo][bar] supported in Markdown?

[tipiirai]

btw: Nuemark will not support raw HTML, because that violates the separation of concerns principle

[nobkd]

Are image reflinks like ![foo][bar] supported in Markdown?

The commonmark reference implementation does support it: https://spec.commonmark.org/dingus/?text=!%5Bimg%5D%5Btag%5D%0A%0A%5Btag%5D%3A%20%2Fimg.png%0A#result

(PS: did you do the strike through implementation with one tilde (~) or with two (~~)? ~strike~ oder ~~strike~~? Also, may I know why you used the pipe symbol |marked text| for <mark> and not the (in my opinion) more commonly used ==marked text==? To be more similar to glow?) (PPS: do we have a simple way to write <details> with <summary>?)

Edit : you can btw remove marked from this tourimage: https://github.com/nuejs/nue/blob/dev/packages%2Fnuejs.org%2Ftour%2Fimg%2Fnpm-nue.png (maybe remove node modules and do a clean install on dev, to get all the dependency changes)

[nobkd]

Found more problems:

1. **bold** not bold **bold**
2. **test**:

expected:

<ol>
  <li><p><strong>bold</strong> not bold <strong>bold</strong></p></li>
  <li><p><strong>test</strong>:</p></li>
</ol>

reality:

<ol>
  <li><p><strong>bold** not bold **bold</strong></p></li>
  <li><p>**test**:</p></li>
</ol>

You can see this issue e.g. on the docs index page in on dev branch: http://localhost:8080/docs/

Edit: maybe the ps should not belong to the list items?

[nobkd]

Nuemark also doesn't support <br> line breaks using two or more spaces at the end of a line or a backslash at the end of a line:

foo  
bar

foo\
bar

expected:

<p>foo<br />
bar</p>
<p>foo<br />
bar</p>