removing line about single RUN statement

nuest / ten-simple-rules-dockerfiles

Ten Simple Rules for Writing Dockerfiles for Reproducible Data Science

https://doi.org/10.1371/journal.pcbi.1008316

Creative Commons Attribution 4.0 International

61 stars 15 forks source link

removing line about single RUN statement #59

Closed vsoch closed 4 years ago

vsoch commented 4 years ago

it can be argued either way about a line installing and cleaning up (or not) - the "best" case really depends on the container and use case in question. For these reasons, we should not have a statement so bold that says the behavior should be done or avoided.

@nuest I pulled the latest from master, so I'm not sure why we are seeing other changes here...

Signed-off-by: vsoch vsochat@stanford.edu

vsoch commented 4 years ago

@nuest did you have any force pushes that might have corrupted my git tree with changes that are no longer present in the tree?

vsoch commented 4 years ago

@nuest this is scary - I'm making changes from a fresh clone, and knitting, and there are clear changes that I didn't make, and bugs in the rendering...

vsoch commented 4 years ago

This was reopened in #60 - the issue (I think) is that someone has contributed changes without properly knitting them into the second file. So I don't think I'm looney, just not expecting the build to be broken / unmatched like that.