nuest / ten-simple-rules-dockerfiles

Ten Simple Rules for Writing Dockerfiles for Reproducible Data Science
https://doi.org/10.1371/journal.pcbi.1008316
Creative Commons Attribution 4.0 International
64 stars 15 forks source link

Submission #69

Closed nuest closed 4 years ago

nuest commented 4 years ago
nuest commented 4 years ago

@sje30 Since we make a new submission, should do it to become corresponding author?

It would of course be welcome if you can help out with a cover letter again.

vsoch commented 4 years ago

@nuest I'm not familiar with CRediT, what do you need me to do?

nuest commented 4 years ago

@vsoch You have taken a look at the contribution section, and already fixed the roles, so you're good.

nuest commented 4 years ago

Timeline

Let's target Wed May 20 as a deadline for the visual summary and changes to the text. Then, everyone will have one week to take another look at the full draft to comply with the authorship requirements and I will submit on May 29.

Please ensure you schedule enough time to check the final draft between May 20 and 29 and let me know if that does not work for you.

nuest commented 4 years ago

Author contributions

"I have checked and approve the assigned roles in the author contributions", see https://github.com/nuest/ten-simple-rules-dockerfiles/blob/master/ten-simple-rules-dockerfiles.Rmd#L827

sje30 commented 4 years ago

Deadline looks good to me.

nuest commented 4 years ago

Final version contents

"I have checked and approve the contents of the final revision of the article", see https://github.com/nuest/ten-simple-rules-dockerfiles/tree/submission-sign-off (see changes between preprint.v1 and submission-sign-off).

(The only expected change before submission: visual summary figure by @bdevans. By signing off below you are also fine with small changes in wording or typo corrections after your approval - thanks!)

vsoch commented 4 years ago

Silly question (and let me know if you want new issues posted for these sorts of things) - should the commas around our names be spaced like that? image Are they practicing social distancing? :P

vsoch commented 4 years ago

@nuest I gave my final read over! Please see https://github.com/nuest/ten-simple-rules-dockerfiles/pull/84 a tiny PR with some fixes / suggested changes. And feel free to accept /reject as you see fit. I'm happy to give my seal of approval when that is finished up!

nuest commented 4 years ago

84 is merged - thanks for that! I also find the spacing in the authors list weird, but it's the template they provide, so I'd say, let's fix that after the review :-)

vsoch commented 4 years ago

Thanks @nuest ! I've checked off my box above.

bdevans commented 4 years ago

Hi @nuest, I've checked off my name above in anticipation of merging PR #86. These will hopefully be the final changes before submission! 🥳

sje30 commented 4 years ago

@bdevans thanks for joining this paper, this is an excellent example of open collaboration!

bdevans commented 4 years ago

It's been a pleasure @sje30 - thanks to all for including me! 😊

nuest commented 4 years ago

@psychemedia friendly ping! I hope you find the time to give the text another read, because there were significant changes since we've last conversed on the paper, and I still found a few small mistakes this morning.

psychemedia commented 4 years ago

@nuest APols for tardiness; I've ticked off required checkboxes and made some minor language change suggestions in branch th-final-comments if you want to cherry pick any of them.

bdevans commented 4 years ago

They look like good edits to me @psychemedia - would you like to submit them as a PR so that they can be merged into the main repo?

nuest commented 4 years ago

Thanks everyone! I'll keep you posted on the next steps.

nuest commented 4 years ago

Preprint updated base on the Travis CI rendering, now at version 5: https://osf.io/download/5e9964fbf135350557d5a298/?version=5&displayName=ten-simple-rules-dockerfiles-2020-06-16T10%3A28%3A50.369Z.pdf


Preserving the "OKs" in case the journals asks:

image

image

nuest commented 4 years ago

image