search

nuest / ten-simple-rules-dockerfiles

Ten Simple Rules for Writing Dockerfiles for Reproducible Data Science
https://doi.org/10.1371/journal.pcbi.1008316
Creative Commons Attribution 4.0 International
61 stars 15 forks source link

Editorial review #73

Closed CRBrennecka closed 4 years ago

vsoch commented 4 years ago

@CRBrennecka you should rebase with master so that we don't see these commits from @nuest here.

nuest commented 4 years ago

IMO this is ready to be merged - the open discussions between @vsoch and @nuest do not concern the this PR's content but issues that surfaced during its review. I have a call scheduled with @CRBrennecka to discuss how the review went (it was her first time using GitHub :tada:) and can ask her to double-check the changes I pushed to the source branch: