Improve and clarify bind mounts vs. volumes

nuest / ten-simple-rules-dockerfiles

Ten Simple Rules for Writing Dockerfiles for Reproducible Data Science

https://doi.org/10.1371/journal.pcbi.1008316

Creative Commons Attribution 4.0 International

61 stars 15 forks source link

Improve and clarify bind mounts vs. volumes #77

Closed nuest closed 4 years ago

nuest commented 4 years ago

data should remain bind mounted
volumes can be used for persisting changes within the image > they should be discouraged for reproducible data science
all changes should be under version control in the repo where the Dockerfile is
volume mounts would be faster if e.g. a fast database connection is needed
mention volume only in rule about ordering, so users are aware of the implications
only (large) data files should be mounted, unless an IDE container is used (Jupyter)

nuest commented 4 years ago

@bdevans All bullet points covered covered, except the one about the IDE container, right? Since that aspect would complicate the rules, I will follow your decision if you prefer not to cover it.

bdevans commented 4 years ago

Hi @nuest, that point is covered in the following under the current Rule 9 (One Docker & use VCS):

If you prefer to edit your scripts more interactively in a running container (e.g., using Jupyter) then it may be more convenient to bind mount their directory from the host at run time, provided all changes are commited before sharing.

Does that suffice? If not we could repeat the point elsewhere.

nuest commented 4 years ago

My bad, I need to call it a day. :sleepy: