nugget / python-insteonplm

Python 3 asyncio module for interfacing with Insteon Powerline modems
MIT License
33 stars 19 forks source link

Hub version 1 and windows windows #100

Closed teharris1 closed 6 years ago

teharris1 commented 6 years ago

Addresses the following issues:

wz2b commented 6 years ago

This change caused things to break for me:

transport, protocol = yield from create_serial_connection(
                    self._loop, lambda: self.protocol,
                    self.device.upper(), baudrate=19200)

with this exception:

serial.serialutil.SerialException: [Errno 2] could not open port /DEV/TTYUSB0: [Errno 2] No such file or directory: '/DEV/TTYUSB0'

A previous version did some test about os.name == 'nt' which only did the upper() if you are windows. I think this needs to test whether or not it needs to do that conversion again.

teharris1 commented 6 years ago

Please don't comment in closed PRs. there is an issue open for Windows support. Please post here:

79