search

nugget / python-insteonplm

Python 3 asyncio module for interfacing with Insteon Powerline modems
MIT License
33 stars 19 forks source link

First steps towards Python 3.7 support #107

Closed scop closed 5 years ago

scop commented 6 years ago

Start testing with it (allowing failures for now), and fix the lowest hanging issue. There are more things to fix, highlighted by the test failures, but it's a start that I think could be merged as is already in this form.

The sudo: required is (transitional, I believe) weirdness that is/was required for Travis Python 3.7 at least some time ago.

teharris1 commented 5 years ago

@scop Thanks for contributing! How would you feel about taking this all the way before committing it? In other words, I think all that needs to be done is to replace all asyncio.coroutine decorators with async and then replacing yield from with await. This will break the 3.4 support but that is probably OK at this point. 3.5 and above are breaking to 3.4 anyway so at some point we have to make that change. Thoughts?

scop commented 5 years ago

No problem dropping 3.4 support here. But then again, I'm not directly using this module myself at all, just took a brief look at a Home Assistant issue report.

teharris1 commented 5 years ago

OK, then I am going to close this PR and start a new one that fully supports 3.7. I have a few other things on the backlog then will do this.