nugget / python-insteonplm

Python 3 asyncio module for interfacing with Insteon Powerline modems
MIT License
33 stars 19 forks source link

Leak sensor reporting 'wet' when it is dry #52

Closed teharris1 closed 6 years ago

teharris1 commented 6 years ago

Leak sensor indicates the device is wet when it is dry Issue is the daily heartbeat is being seen as an 'on' command. Device needs to be rewritten to support groups 0x01 Dry 0x02 Wet and 0x04 Heartbeat.

teharris1 commented 6 years ago

Test code available:

Module insteonplm: insteonplm/devices/securityHealthSafety.py insteonplm/states/sensor.py

Module homeassistant: homeassistant/components/insteon_plm.py homeassistant/components/binary_sensor/insteon_plm.py Please replace the current files with these files and restart HA. I have tested the code as best I can but I don't own one of these leak sensors so I cannot test if it works.

teharris1 commented 6 years ago

This has been reasonably tested.

@nugget I put a version in the version database. Can we push to pypi? Alternatively, can you give me admin access to pypi for this module?

nugget commented 6 years ago

v0.8.3 pushed to PyPI. Would be glad to add you to the project there, are you https://pypi.org/user/teharris/ ?

teharris1 commented 6 years ago

Updated in Home Assistant too.

teharris1 commented 6 years ago

@nugget Yes I am teharris on pypi.