nuhrin / pandafe

"Universal" SDL frontend for Pandora
GNU General Public License v3.0
5 stars 0 forks source link

Bug/Issue report: cue/bin files problem with PCSXReARMed #25

Closed ekianjo closed 10 years ago

ekianjo commented 11 years ago

I noticed that I did remove some bin files from my PCSX folder but left the cue files in there. Apparently Pandafe detected the cue files present as games even though the equivalent bin is not there anymore. Not a big deal, but I would expect to have such a check by Pandafe automatically:

if cue-file detected -> check if bin-file present -> if yes -> display game, if not -> do not display

nuhrin commented 11 years ago

Hmm, yeah. Pandafe works from the assumption that roms can be reasonably represented by a single file which is used to launch the game.

Various platforms have various more complex ways to represent a game, often multiple distinct ways. In some case, the various ways to represent a game are also emulator specific.

Using that single consistent assumption of a single file representing a runnable game helps make possible the generalized rom-platform concept, so its important as a baseline.

Further platform-specific logic is certainly possible, though the possibilities are vast enough that it probably would need to be moved to shell script (stored with the Platform definition as data) to avoid introducing various hard-coded platform details (which is contrary to the design).

Using shell scripts is a pain for various other reasons, but I'm doing something similar already for program-based platforms (ScummVM), so perhaps I can look along those lines in the future.

For this issue specifically, a complete description of all the combinations of file extensions which represent a valid game would be helpful.

ekianjo commented 11 years ago

OK, i'll go and ask Notaz exactly what formats he supports for PCSXreARMed and I'll come back to you with a clear answer in a couple of days :)

nuhrin commented 11 years ago

I ended up implementing this as part of another feature: rom management (rename, move, delete), as mentioned in the pandafe post on pandoralive.

Basically, I started parsing cue files in order to make sure the rom management features treated files specified in .cue files as part of the rom. As part of that, cue files are treated specially during rom scanning, including the specific behavior you requested in your bug report.

This will be included once I release the rom management feature (soon, hopefully).

nuhrin commented 10 years ago

Fix/feature included in recently released 0.3.0 (finally...)