search

nuke-build / nuke

🏗 The AKEless Build System for C#/.NET
https://nuke.build
MIT License
2.94k stars 357 forks source link

Azure Artifacts Credential Provider Integration #1070

Open rena0157 opened 1 year ago

rena0157 commented 1 year ago

Description

Essentially complete the same functions that using the NugetAuthenticate@1 does in a pipeline. Or even simply allowing for an additional step in the [AzurePipelines] that inserts the NugetAuthenticateTask before other tasks.

Usage Example

The proposed feature could be used as a part of the [AzurePipelines] auto-generation feature.

Alternative

There is no real good alternative that I have found. Right now you can do either of the following:

Megasware128 commented 1 year ago

This feature should be very easy to implement. I've done it before.

References: https://github.com/Megasware128/nuke-extensions/blob/main/Nuke.Extensions/Configuration/AzurePipelinesNuGetAuthenticateStep.cs https://github.com/Megasware128/nuke-extensions/blob/7a6101549502f94278b92c9f758f1f1dd70035e7/Nuke.Extensions/AzurePipelinesExtendedAttribute.cs#L40

Basyras commented 1 year ago

I am surprised it is not part of the default attribute yet. Not very elegant to force everyone write their custom attributes to perform something as common as this

matkoch commented 1 year ago

@Basyras I suggest you get familiar with the contribution guidelines

Basyras commented 1 year ago

@matkoch looking back on what I just wrote i would express that in different way. Sorry. I didn't tried to be mean just tried to give feedback/ show support/upvote for this issues.

The comment is not driven by my personal interest I genuinely think it should be part of the nuke since I find it very common. Something I assume majority of developers using azure pipelines must have issue with.

I don't want just complain I am willing to contribute if you agree the issue should be addressed by nuke.

PS: Sorry for spamming the thread

ITDancer13 commented 2 months ago

I think, I've implemented what you're looking for in this PR https://github.com/nuke-build/nuke/pull/1397

From my point of view this is really helpful as it simplifies to work with private feeds in Azure DevOps