nuke-build / nuke

🏗 The AKEless Build System for C#/.NET
https://nuke.build
MIT License
3.07k stars 367 forks source link

Use shellcheck --severity=warning on all shell scripts #1371

Closed johnbley closed 5 months ago

johnbley commented 7 months ago

When using nuke in a project and applying shellcheck --severity=warning (a wonderful shell linting tool), it turned up a minor nit in nuke's build.sh. So, it was suggested by a colleague that I fix this "at the source" 😄 .

I confirm that the pull-request:

matkoch commented 7 months ago

Could you give some information on what the actual warning is?

johnbley commented 7 months ago

Could you give some information on what the actual warning is?

Oh! Sure thing! Basically we don't want to ignore the return value of command -v dotnet:

SC2155 (warning): Declare and assign separately to avoid masking return values.

https://www.shellcheck.net/wiki/SC2155

matkoch commented 5 months ago

2024-05-30-Arc-ChatGPT-003675