search

nuke-build / nuke

🏗 The AKEless Build System for C#/.NET
https://nuke.build
MIT License
2.86k stars 348 forks source link

Bug in Arguments.cs #170

Closed hayhay27 closed 5 years ago

hayhay27 commented 5 years ago

Secret's value falls in customValue argument: https://github.com/nuke-build/nuke/blob/6787fedf3abd411ed1f98b18174ebd7fb465b34a/source/Nuke.Common/Tooling/Arguments.cs#L45

Signature: https://github.com/nuke-build/nuke/blob/6787fedf3abd411ed1f98b18174ebd7fb465b34a/source/Nuke.Common/Tooling/Arguments.cs#L48-L53

matkoch commented 5 years ago

That's a nasty bug, thanks for reporting. How did you notice?

hayhay27 commented 5 years ago

Just extending ToolSettings for SonarQube tool I looked under hood

matkoch commented 5 years ago

Just to make sure, do you know that we use code generation to add support for CLI tools?

hayhay27 commented 5 years ago

Yes, I know. From dotnext video. But forgot. Sometimes, it's not so bad)

lock[bot] commented 4 years ago

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.