nuke-build / nuke

🏗 The AKEless Build System for C#/.NET
https://nuke.build
MIT License
3.09k stars 373 forks source link

Support both Helm2 and Helm3 #854

Open SierraNL opened 2 years ago

SierraNL commented 2 years ago

Description

Currently there is a single Helm task. But between Helm versions 2 and 3, quite some major changes to the cli have been made. They are described here: https://helm.sh/docs/topics/v2_v3_migration/

I already noticed there is a PR already open for a long time with a regeneration for Helm 3 (but I think that could break Helm 2): #578 and a recent pr #839 to add a single new Helm 3 parameter.

My suggestion would be to rename the current tasks to Helm 2 and add a freshly generated Helm 3. But since this would be breaking it would be best to do this on a major version bump.

Usage Example

No response

Alternative

chrsin commented 3 months ago

It's not possibly to supply a release name for the HelmTemplate task at the moment.

If you use SetName it will supply the --name parameter which is obsolete per: https://helm.sh/docs/helm/helm_template/