nuke-haus / mapnuke

An open-source map generator for Dominions 5 and 6
http://map.nuke.haus
GNU General Public License v3.0
25 stars 14 forks source link

A few bugs #22

Closed Jrayp closed 3 weeks ago

Jrayp commented 7 months ago

Just what Ive seen immediately:

image image image image

Jrayp commented 7 months ago

Just noticed that (apart from the layer issue you seem to have fixed with the last commit):

Provinces only seem to have the mountain flag when they have a mountain connection. This means impassable and mountain passes dont result in mountain provinces which is really jarring

edit:

Aw i see this is by design:

if (GeneratorSettings.s_generator_settings.UseClassicMountains && !terr.IsFlagSet(Terrain.MOUNTAINS) && mountain_count(m) >= 1f)
                {
                    terr = terr.SetFlags(Terrain.MOUNTAINS);
                }

Personally Id say a single mountainpass should still give the mountain flag but thats me