search

nukeop / nuclear

Streaming music player that finds free music for you
https://nuclearplayer.com
GNU Affero General Public License v3.0
12.19k stars 1.06k forks source link

Back arrow when in search results should preserve state #1068

Open echo-bravo-yahoo opened 3 years ago

echo-bravo-yahoo commented 3 years ago

Steps:

  1. Search for an album (or group of related albums); you'll now be on the All tab.
  2. Click on Albums tab.
  3. Scroll through several pages of albums, then click on a specific album.
  4. Click the back arrow.
  5. Note that you're back on the All tab, with the context about the albums you'd scrolled past dropped.

It would be really helpful if it preserved the tab you were on and scrolled the element you'd interacted with into view.

brandon-hoang-le commented 3 years ago

Hey @nukeop, I am very new to this but I would like to give this a try if possible. Any tips or suggestions would be great as well!

nukeop commented 3 years ago

I'm not sure, but I'd probably try these approches:

https://stackoverflow.com/questions/29203312/how-can-i-retain-the-scroll-position-of-a-scrollable-area-when-pressing-back-but https://medium.com/@mikolajkocieda/react-hooks-keep-scroll-position-during-change-list-views-cd86463f9629

Or something similar. Definitely some original method is required.

brandon-hoang-le commented 3 years ago

Thank you for these suggestions. I'll see what I can do and let you know if I make any progress!

brandon-hoang-le commented 3 years ago

Hey @nukeop I won't be able to make progress anytime soon. Could you unassign me from this issue? I'll see if I can give this another try in the future if it is still available. Thank you.