search

nukeop / nuclear

Streaming music player that finds free music for you
https://nuclearplayer.com
GNU Affero General Public License v3.0
12.22k stars 1.07k forks source link

Nuclear doesn't download verified streams. #1484

Open Saltane opened 1 year ago

Saltane commented 1 year ago

Platform: Linux Nuclear version: 0.6.27 (AUR) Description of the issue: Issue is quite simple. There's a track which if unverified plays undesired stream. After verifying named track to desired stream, download feature of Nuclear downloads track from undesired stream mentioned before. Expected behaviour: After verifying a track, Nuclear will download correct, verified stream.

nukeop commented 1 year ago

Since downloading is implemented in a different place, it does not share the code that normally checks the verification service for matches. It should be added there.

dhananjay-Byte commented 1 year ago

@nukeop i would like to work on this issue. can you assign me this?

nukeop commented 1 year ago

I don't assign issues, but you're free to open a pull request.

Krishcode264 commented 4 months ago

@nukeop I've submitted a pull request #1626 that addresses the issue where Nuclear doesn't download verified streams. This enhancement allows users to select and download the desired stream directly, improving the download accuracy.

You can view the pull request here Please review and provide any feedback or suggestions. Thank you!

nukeop commented 4 months ago

I decided to close that PR.

Krishcode264 commented 4 months ago

@nukeop yeah i see , we have multiple streams for single track , when user changes the stream for perticular track from the play queue and try to download it from there , it doesnt download that newly selected stream but it always download track.streams[0] , how about if we could add the selectedStreamId to track object when selectNewStream() methode calls so that download service would know what perticular stream has to download for that track , thats what i had implemented in that PR