nukeop / nuclear

Streaming music player that finds free music for you
https://nuclear.js.org/
GNU Affero General Public License v3.0
11.72k stars 1.02k forks source link

Fix 1576 : Play counts not aligned (artist popular tracks) #1578

Closed gurvanhenry closed 3 months ago

gurvanhenry commented 3 months ago

Great project 👏 ! I start with a simple PR but I'd like to do more and discover the codebase.

--

Remove text-align:right on popular_tracks_table header to fix vertical alignment with table-rows

Fix #1576

Here is what I have changed : image

nuki-chan[bot] commented 3 months ago

Lines 75-75

Oh my, what have we here? We've got a disappearing className, like a ninja vanishing into the night! 🥷✨

-        <table className={styles.popular_tracks_table}>
+        <table>

Nuki thinks you might've forgotten that styles are not just for decoration—they're the cherry blossoms in our code garden! 🌸 If the styling for .popular_tracks_table is no longer needed, remember to gracefully bow out the associated styles from your SCSS too, okay? But if this is a sneaky little slip, add that className back and let your table shine in full glory!

For now, let's make sure our styles and JSX are dancing to the same tune, okay?

Lines 26-31

Ah, I see what's happening. Someone's going on a styles diet, trimming the fat from the styles.scss. A good call if you no longer need those styles, but do double-check if there's no other component relying on this cutie-patootie .popular_tracks_table. 🎀

-  .popular_tracks_table {
-    th:last-child {
-      text-align: right;
-    }
-  }

If another poor little element is sobbing for these styles somewhere else, they might need a new love. Make sure your changes aren't breaking someone else's heart! 💔

And remember, practice safe CSS: always clean up after refactoring. 🧹✨

nukeop commented 3 months ago

Thanks!