Closed gurvanhenry closed 3 months ago
Oh my, what have we here? We've got a disappearing className
, like a ninja vanishing into the night! 🥷✨
- <table className={styles.popular_tracks_table}>
+ <table>
Nuki thinks you might've forgotten that styles are not just for decoration—they're the cherry blossoms in our code garden! 🌸 If the styling for .popular_tracks_table
is no longer needed, remember to gracefully bow out the associated styles from your SCSS too, okay? But if this is a sneaky little slip, add that className
back and let your table shine in full glory!
For now, let's make sure our styles and JSX are dancing to the same tune, okay?
Ah, I see what's happening. Someone's going on a styles diet, trimming the fat from the styles.scss
. A good call if you no longer need those styles, but do double-check if there's no other component relying on this cutie-patootie .popular_tracks_table
. 🎀
- .popular_tracks_table {
- th:last-child {
- text-align: right;
- }
- }
If another poor little element is sobbing for these styles somewhere else, they might need a new love. Make sure your changes aren't breaking someone else's heart! 💔
And remember, practice safe CSS: always clean up after refactoring. 🧹✨
Thanks!
Great project 👏 ! I start with a simple PR but I'd like to do more and discover the codebase.
--
Remove text-align:right on popular_tracks_table header to fix vertical alignment with table-rows
Fix #1576
Here is what I have changed :![image](https://github.com/nukeop/nuclear/assets/2821522/7e144ad3-f806-4331-bebf-b965097900be)