search

nukeop / nuclear

Streaming music player that finds free music for you
https://nuclear.js.org/
GNU Affero General Public License v3.0
11.93k stars 1.03k forks source link

Visual bug in local library progress bar #1644

Open rkben opened 1 month ago

rkben commented 1 month ago

Platform: macOS Sonoma 14.5, arm64

Nuclear version: git master: https://github.com/nukeop/nuclear/commit/022ba2b98302939222bbe7dabb397ef0934c3b51

Description of the issue: Visual bug in local library progress bar. I suspect this is due to the width of the characters in the total number 34857. The currently scanned count is not viewable at all until its width is 4 characters wide.

image

nukeop commented 1 month ago

You're right, we're using this library: https://react.semantic-ui.com/modules/progress/

I guess this can be handled by CSS. By the way, did you notice any improvement in the scanning time? Did it handle your library well?

rkben commented 1 month ago

Bit of padding looks like it fixed it without looking too strange. Demo: https://codesandbox.io/s/semantic-ui-example-forked-9rvtl5?file=/example.js

.progress {
    .bar {
        padding-left: 100px;
    }
}

RE: library scan I'd say its on par with other media players such as Foobar2000 and Cog. Around 1 hour to import (give or take 20 minutes). The UI interaction being locked for an extended period of time is a bit annoying, but that's typical behavior with large libraries in other audio players.

It does seem to crash eventually once it tries to display the entries, but that was with devtools open and running in development mode. Another scan is in progress using the release build.

Edit: Off-topic scanner performance continued in #help thread via Discord.