search

nukeop / nuclear

Streaming music player that finds free music for you
https://nuclearplayer.com
GNU Affero General Public License v3.0
12.13k stars 1.06k forks source link

"The Death & Resurrection Show" by "Killing Joke": an error has occurred when searchin… #1683

Open Lucki opened 2 months ago

Lucki commented 2 months ago

Fill in the form to describe your problem I have a problem with: "The Death & Resurrection Show" by "Killing Joke" https://open.spotify.com/track/2JUo8iX8FC05xd9GEpw9BI It happens when: I try to play it/Adding the song to a queue My OS is: Linux/Flatpak I'm using Nuclear version: 0.6.38

Additional context config.json

When adding to the queue, the entry stays red and rotates forever, reporting an error has occurred when searchin…

nukeop commented 2 months ago

Likely due to: https://github.com/distubejs/ytdl-core/issues/92

GearKite commented 1 week ago

Might not be that.

At queue.ts#L197 if a song has a verified video, but that video is not returned in the search results, streamData will start with undefined ([undefined, ...]), which is then passed to resolveSourceUrlForTheFirstStream and causes a TypeError: Cannot read property 'stream' of undefined at queue.ts#L257.

Can also check that when disabling stream verification, this doesn't happen.

nukeop commented 1 week ago

That's a great observation. Unfortunately Youtube returns different search results for different people. If there's already a verified stream, it should use it without even searching for it. The search can happen later, so that the list of alternative streams can be populated.