nukeop / nuclear

Streaming music player that finds free music for you
https://nuclearplayer.com
GNU Affero General Public License v3.0
12.16k stars 1.06k forks source link

The sort symbol does not match the sort #1703

Open Korb opened 1 month ago

Korb commented 1 month ago

Platform:

Windows

Nuclear version:

About Nuclear Music Player Desktop music player for streaming from free sources Copyright © nukeop 2024, released under AGPL-3.0 Many thanks to our contributors on Github, your help was vital in creating this program. Submit issues or new features This program is free software: you can redistribute it and/or modify it under the terms of the GNU Affero General Public License as published by the Free Software Foundation, either version 3 of the License, or (at your option) any later version. See the GNU Affero General Public License for more details.

Description of the issue:

Currently, the Local Library column headers use two types of icons. Both display stylized text strings, supplemented with a down or up arrow.

2024-09-22_11-56-18

The text strings are always displayed from longer (larger) at the beginning to shorter (smaller) at the end. And the arrow is confusing. For more information on the issue of supplementing the sort order symbol with an arrow, see the article "UX Mission: Complex Column Sorting Icons".

I propose replacing these two icons with others that display only the strings (from smaller to larger and vice versa, which would indicate direct and reverse sorting) or even just a triangle with an up and down angle, respectively.

nukeop commented 1 month ago

I just double checked to see if I used the right icons, the ones we're using can be seen here: https://react.semantic-ui.com/elements/icon/

If the rows are sorted in descending order, we use the descending arrow, and vice versa.