nukeop / nuclear

Streaming music player that finds free music for you
https://nuclear.js.org/
GNU Affero General Public License v3.0
11.93k stars 1.03k forks source link

Sleep timer #858

Open azumukupoe opened 3 years ago

azumukupoe commented 3 years ago

a simple sleep timer would be nice addition to the Autoradio feature

nekonee commented 3 years ago

I wonder what would be more appropriate- turning off after X songs or after Y amount of time. Will implement this feature but I'd love some insight on which option would be preferred.

azumukupoe commented 3 years ago

amount of time would be definitely better because track length vary and it should come with an option to finish the track after running out of time

for reference, AIMP has a good sleep timer although it isn't open source

image

nekonee commented 3 years ago

That's a nice reference, thanks. Will work on that today.

hnrq commented 3 years ago

A behavior that just ran into my mind is: Will the timer be paused alongside a song? 🤔

azumukupoe commented 3 years ago

As I said earlier, it should be toggleable to whether finish the current track or not

hnrq commented 3 years ago

Oh, sorry, I think I misused some words 😅. For example: let's say that I've set a time for 30 minutes from now, and, after 5 minutes have elapsed, I decided to pause the song. Should the timer also stop counting?

azumukupoe commented 3 years ago

Trying that it with AIMP, the timer is still counting after pausing music

mariuscernescu commented 3 years ago

Hi, Is anybody working on this?

nukeop commented 3 years ago

Yes, it's already been finished, I just have to merge it.

Sanju3001 commented 2 years ago

@nukeop Is this issue still open?

nukeop commented 2 years ago

I guess so, we haven't merged that in the end.

Nirbhayparmar commented 2 years ago

Oh, sorry, I think I misused some words 😅. For example: let's say that I've set a time for 30 minutes from now, and, after 5 minutes have elapsed, I decided to pause the song. Should the timer also stop counting?

Timer should not paused on pausing the song, according to me.

Andres-Ventura commented 1 year ago

@nukeop Is this issue still available to work on?